Skip to content

Setup TS change to allow skipping the containers setup.#440

Open
jp-tosca wants to merge 3 commits intodevelopfrom
containers_skip
Open

Setup TS change to allow skipping the containers setup.#440
jp-tosca wants to merge 3 commits intodevelopfrom
containers_skip

Conversation

@jp-tosca
Copy link
Copy Markdown
Contributor

@jp-tosca jp-tosca commented Apr 20, 2026

What this PR does / why we need it:

When running tests, containers are started to run against but there are use cases like development or more complicated configurations that would be helpful to run against local installations that have been set up in a different way.

You can run a test for example with
npm run test GetCollection
or
SKIP_CONTAINERS=true npm run test GetCollection

You could also set const SKIP_CONTAINERS in setup.ts

Copilot AI review requested due to automatic review settings April 20, 2026 15:22
@jp-tosca jp-tosca moved this to Ready for Review ⏩ in IQSS Dataverse Project Apr 20, 2026
@jp-tosca jp-tosca added the GREI Re-arch GREI re-architecture-related label Apr 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to allow running the Jest test suite without starting Docker containers, enabling tests to run against an already-running local instance.

Changes:

  • Adds an optional skipContainers parameter to setupContainers.
  • Adds an inline comment implying containers can be skipped.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/environment/setup.ts Outdated
@cmbz cmbz added FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) labels Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) GREI Re-arch GREI re-architecture-related

Projects

Status: Ready for Review ⏩

Development

Successfully merging this pull request may close these issues.

3 participants